-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature/bat-45 #2
base: develop
Are you sure you want to change the base?
Conversation
- move rapidjson submodule to thirdparty/ to avoid confusion with include/ - added thirdparty/build.sh as hack to setup dependencies before running autotools - updated gitignore to include outstation app - update gitignore to include outstation app - implemented JSONCommandHandler that currently only prints out JSON representation of DNP3 commands - added analog output test function in master demo and code-formatted Conflicts: Makefile.am thirdparty/rapidjson
- AsyncCommand refers to pointers to allow multiple types being set (NULL otherwise) - AsyncCommandHandler queues commands using blocking queue w/ one subscriber supported - OutstationJSONTCPServer tracks multiple sessions and publishes AsyncCommands to all - JSONTCPSession writes AsyncCommands received to stdout, needs to write to socket_ - lock/thread/queue updated to C++11 std implementations
@@ -34,8 +34,7 @@ using namespace asiopal; | |||
using namespace asiodnp3; | |||
using namespace opendnp3; | |||
|
|||
int main(int argc, char* argv[]) | |||
{ | |||
int main(int argc, char* argv[]) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a bunch of these code-style changes here, are they legit? Does the parent project have a style guide?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is a code formatting command here, although it touches a bunch of files already in the repository too. I'll run it on the shared code so at least that part will be formatted correctly.
https://github.com/automatak/dnp3-guide/blob/master/mkdoc/docs/contributing/tasks.md
- add AsyncCommandQueue that is used by all instances of AsyncCommandHandlers for sending commands to the OutstationJSONTCPServer (publish/subscribe), attempted boost:signals2 but ran into issues (turns out they were not related to signals2 - so it may be worth revisiting) - add AsyncCommand "id" support for handling multiple outstations
Please provide any feedback as I am just getting back into the C++ world and learning of C++11 features/paradigms